Use identifier in HarvesterGroup in filestream#24864
Merged
kvch merged 1 commit intoelastic:masterfrom Mar 31, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures> Show only the first 10 test failures
|
| Test | Results |
|---|---|
| Failed | 66 |
| Passed | 13127 |
| Skipped | 2271 |
| Total | 15464 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / filebeat-build / test_fileset_file_060_traefik – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_061_nginx – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_062_nginx – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_063_nginx – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_064_nginx – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_067_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_068_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_069_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_070_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_071_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_072_iis – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_106_apache – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_107_apache – filebeat.tests.system.test_modules.Test - Name:
Build&Test / filebeat-build / test_fileset_file_108_apache – filebeat.tests.system.test_modules.Test - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_048_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_049_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_051_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_052_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_053_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_054_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_055_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_056_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_057_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_058_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_059_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_060_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_061_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_062_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_063_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_064_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_065_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_066_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_067_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_068_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_069_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_070_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_071_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_072_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_073_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_074_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_075_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_076_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_077_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_078_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_079_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_081_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_082_aws – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_131_zeek – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_139_f5 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_141_zscaler – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_142_zscaler – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_145_tomcat – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_173_o365 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_178_o365 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_179_o365 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_180_o365 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_181_o365 – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_221_gcp – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_252_envoyproxy – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_253_envoyproxy – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_255_suricata – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_256_suricata – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_257_suricata – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_264_squid – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_271_okta – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest - Name:
Build&Test / x-pack/filebeat-build / test_fileset_file_301_azure – x-pack.filebeat.tests.system.test_xpack_modules.XPackTest
5223c8d to
43a9ccd
Compare
1 task
urso
approved these changes
Mar 31, 2021
43a9ccd to
356f306
Compare
Contributor
Author
|
Failing tests are unrelated, PR to fix it: #24871 |
3 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Mar 31, 2021
(cherry picked from commit 23bfcd9)
kvch
added a commit
that referenced
this pull request
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
sourceIdentifiertodefaultHarvesterGroupso it uses the same method to access entries in the registry as theProspector.Why is it important?
Previously, the
HarvesterGroupandProspectorlooked for the same resources but got different IDs.HarvesterGroupwas not aware of thefilestream::{user_id}prefix, thus theProspectornever found the entries created by theHarvesterGroupand vica versa.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.